Commit Graph

372 Commits

Author SHA1 Message Date
Aaron Marcher 95ceafcae7 Merge pull request #39 from stoeckmann/fgets
On success, fgets always terminates the result.
2017-04-20 22:14:56 +02:00
Tobias Stoeckmann 35295f1902 On success, fgets always terminates the result.
If fgets succeeds, then the resulting char array is always
terminated by a '\0'. No need to keep extra space, therefore
sizeof(buf) is the correct argument.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2017-04-04 21:27:31 +02:00
Aaron Marcher 1289bdb742 Merge pull request #38 from stoeckmann/terminating-nul
Fixed out of boundary write on long lines.
2017-04-02 15:27:09 +02:00
Tobias Stoeckmann b1e7c40b21 Fixed out of boundary write on long lines.
The terminating nul character ('\0') could be written outside the boundary of
the buffer which is used to read characters. If "sizeof(buffer)" characters
are read, the resulting value must not be used as index, because that's an off
by one.

Read sizeof(buffer)-1 bytes instead.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
2017-04-02 13:12:03 +02:00
Aaron Marcher cceeec0efa
loading thresholds state 2017-03-30 17:32:20 +02:00
Aaron Marcher b11dd2db0e
Fixed XCloseDisplay() which is not reached in keyboard_indicators() 2017-01-23 21:01:41 +01:00
Aaron Marcher 823f2d047f
Added keyboard_indicators (Fixes #31) 2017-01-16 12:10:56 +01:00
Aaron Marcher 3f976aabc0
Makefile fix and vol_perc fix for mute 2017-01-09 12:05:29 +01:00
Aaron Marcher a3cb24c438
simplified Makefile 2017-01-09 09:29:58 +01:00
Aaron Marcher 09c3ffe33b
small Makefile tweak 2017-01-09 09:23:17 +01:00
Aaron Marcher bb87736518
Makefile: Added back config.h handling in Makefile 2017-01-09 09:21:18 +01:00
Aaron Marcher 98d655c8d0
Makefile: Fixes #35 2017-01-09 08:24:26 +01:00
Aaron Marcher 99bc258586
todo 2017-01-07 22:34:45 +01:00
Aaron Marcher 0d1f19d777
removed ./extern/ 2017-01-07 22:33:28 +01:00
Aaron Marcher 688e2e783d
removed strlcat dependency (was used only once) 2017-01-07 22:31:46 +01:00
Aaron Marcher 32bb92453a
got rid of concat.h 2017-01-07 22:01:49 +01:00
Aaron Marcher d1915f0d4d
saner makefile: cleaner, simpler, suckless 2017-01-07 21:49:10 +01:00
Aaron Marcher 3847911771
happy new year! 2017-01-07 21:28:22 +01:00
Aaron Marcher 8a29374783
run_command: strlen() will not function if string is not null terminated 2017-01-07 21:19:40 +01:00
Aaron Marcher 965a71d678
consistent coding style: usage() declaration, eval is a constant 2016-12-30 23:13:21 +01:00
Aaron Marcher 2b148bf2ec Merge pull request #34 from parazyd/master
refactor vol_perc to not depend on alsa libraries
2016-12-30 23:01:14 +01:00
parazyd 13604963bc Merge branch 'master' into master 2016-12-30 14:21:19 +01:00
parazyd 62f4016430
add vol_perc notes, add braces to singleline statements 2016-12-30 12:16:07 +01:00
Aaron Marcher 8fa6229759
why releases for such a small project? useless and overhead! 2016-12-29 23:36:05 +01:00
Aaron Marcher b68925dbef
#undef strlcpy not needed anymore 2016-12-29 23:30:53 +01:00
Aaron Marcher d7fbcb3586
tested wifi 2016-12-29 23:30:17 +01:00
Aaron Marcher e3c9a6f923 Merge pull request #32 from R41z/master
several bugfixes and general improvements, see commits below.
2016-12-29 23:27:57 +01:00
Aaron Marcher 015f832c3a Merge branch 'master' into master 2016-12-29 23:27:44 +01:00
raiz 0a3aa0b4e6 fix TODO markdown syntax && update 2016-12-29 15:37:17 +03:00
raiz b231cd90eb add braces to single statements so drkhsh doesn't be upset 2016-12-29 12:40:43 +03:00
Aaron Marcher 7392dbabeb
kernel_release() coding style and position in code fix 2016-12-28 23:59:19 +01:00
parazyd c2808b6d99
refactor vol_perc to not depend on alsa libraries 2016-12-28 00:41:51 +01:00
raiz cfb4a5d3ff usage(): return success if -h is called && print more appropriate usage, opts can't be all called at the same time, that's why a separator is required 2016-12-27 20:41:40 +03:00
raiz d1dd72bae9 another TODO update 2016-12-27 20:33:28 +03:00
raiz 2994a8d0ba TODO update 2016-12-27 20:32:22 +03:00
raiz cf67aebec5 homepage update 2016-12-27 20:20:45 +03:00
raiz ba0f0998d9 extern/concat.h: don't segfault if count == 0 2016-12-27 20:18:33 +03:00
raiz e9f738b8b6 whhops, my bad 2016-12-27 20:18:09 +03:00
raiz 94e87eb8ba wifi_essid: add boundary check && prevent the use of direct string literal as a format string in snprintf() 2016-12-27 20:14:45 +03:00
raiz 11fec4fa95 don't allow the use of perc if uninitialized 2016-12-27 20:09:07 +03:00
raiz 8b5b72b65e remove misleading comment 2016-12-27 19:57:16 +03:00
raiz 13772c3979 get rid of set_status() since it's only used once 2016-12-27 19:56:11 +03:00
raiz 3c8717f4e0 allow the use of %* symbols in UNKNOWN_STR 2016-12-27 19:53:46 +03:00
raiz 7db4f5cf67 add extra error tests to swap_*() && fix bytes_read bug 2016-12-27 19:49:31 +03:00
raiz a36cb96f27 swap_*(): add more error tests 2016-12-27 19:26:04 +03:00
raiz 862d158b7c fix delay in a cleaner way 2016-12-27 19:12:39 +03:00
raiz 6cab2d5719 remove newlines from warn() in swap_*(), those functions already print a newline after printing string stderr 2016-12-27 19:07:19 +03:00
raiz e1c5476291 inititalize run_command()'s buf to UNKNOWN_STR by default 2016-12-27 18:58:31 +03:00
raiz b7f4541506 remove newline character from run_command() output accurately 2016-12-27 18:57:27 +03:00
raiz 3bfc3bbcae strtok() has no effect on buf && fgets() should have the full buffer length 2016-12-27 18:54:16 +03:00